Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SF-3077 Add UI for mixed training sources #2875

Open
wants to merge 4 commits into
base: feature/SF-2900
Choose a base branch
from
Open

SF-3077 Add UI for mixed training sources #2875

wants to merge 4 commits into from
+636 −222

Conversation

RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Nov 28, 2024 •
edited
Loading

This PR adds the ability to mix in training data from multiple sources. See the balsamiq for the original design.

No training books selected
Mixed Training No Books Selected

Training books selected
Mixed training current books selected

This change is Reviewable

@pmachapman pmachapman force-pushed the feature/SF-2900 branch 2 times, most recently from d49a457 to 4bd2738 Compare December 2, 2024 19:06
@Nateowami
Copy link
Collaborator

Observations:

  • Bulk selecting NT or OT in the top panel doesn't cause the relevant books to update in the bottom panel

@RaymondLuong3 RaymondLuong3 force-pushed the feature/SF-3077-multiple-source-ui branch from 1ac6820 to d58cf38 Compare December 4, 2024 23:35
@RaymondLuong3 RaymondLuong3 marked this pull request as ready for review December 4, 2024 23:35
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.77419% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (ea8054e) to head (deef1aa).

Files with missing lines Patch % Lines
...neration-steps/draft-generation-steps.component.ts 95.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           feature/SF-2900    #2875      +/-   ##
===================================================
+ Coverage            79.86%   79.90%   +0.04%     
===================================================
  Files                  534      534              
  Lines                31014    31082      +68     
  Branches              5014     5050      +36     
===================================================
+ Hits                 24768    24836      +68     
  Misses                5496     5496              
  Partials               750      750

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the feature/SF-3077-multiple-source-ui branch from d58cf38 to b9268e3 Compare December 5, 2024 00:36
@Nateowami
Copy link
Collaborator

Here are some issues I'm seeing:

josephmyers
josephmyers reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@josephmyers josephmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want to add an optional title parameter to the book selection component, which contains the bulk select checkboxes. Then place the project name on the same line as the checkboxes.

Reviewable status: 0 of 14 files reviewed, all discussions resolved

@Nateowami
Copy link
Collaborator

@RaymondLuong3 I should note that when selecting books in bulk, it seems that the first time yous select them it selects correctly, but then upon unselecting and re-selecting it doesn't.

@RaymondLuong3 RaymondLuong3 force-pushed the feature/SF-3077-multiple-source-ui branch from b9268e3 to 231c790 Compare December 5, 2024 22:29
RaymondLuong3
RaymondLuong3 commented Dec 5, 2024
View reviewed changes
Copy link
Collaborator Author

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that. I figured out the main issue was that arrays were being passed around by reference rather than by values. I've cleaned it up and now it works. I've also addressed the extra training books notice and the project label for the multi-book-select component.

Reviewable status: 0 of 16 files reviewed, all discussions resolved

@RaymondLuong3 RaymondLuong3 force-pushed the feature/SF-3077-multiple-source-ui branch from b6d0947 to deef1aa Compare December 6, 2024 22:14
@RaymondLuong3 RaymondLuong3 force-pushed the feature/SF-3077-multiple-source-ui branch from deef1aa to 8a007bb Compare December 9, 2024 20:07
@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Dec 9, 2024
@RaymondLuong3 RaymondLuong3 force-pushed the feature/SF-3077-multiple-source-ui branch from 8a007bb to f2f1d2d Compare December 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmyers josephmyers josephmyers left review comments

Assignees
No one assigned
Labels
will require testing PR should not be merged until testers confirm testing is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaymondLuong3 @Nateowami @josephmyers